Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing tidyverse install from ggplot lesson #243

Merged
merged 4 commits into from
Dec 13, 2023

Conversation

sstevens2
Copy link
Contributor

fixes #237

This change has us install and load ggplot2 instead of the tidyverse which we know takes a while to install on the AWS machines in particular. It also loads readr and dplyr for the ggplot episode.

Copy link

github-actions bot commented Dec 4, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/genomics-r-intro/compare/md-outputs..md-outputs-PR-243

The following changes were observed in the rendered markdown documents:

 03-basics-factors-dataframes.md |   2 +-
 06-data-visualization.md        |  45 ++++++++++++++++++++++++++--------------
 depth.pdf                       | Bin 45066 -> 45066 bytes
 md5sum.txt                      |  36 ++++++++++++++++----------------
 4 files changed, 49 insertions(+), 34 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-12-04 22:42:50 +0000

@sstevens2
Copy link
Contributor Author

Please especially review for if we need to load any other tidyverse packages for this lesson.

github-actions bot pushed a commit that referenced this pull request Dec 4, 2023
@naupaka
Copy link
Member

naupaka commented Dec 13, 2023

Thanks!!

@naupaka naupaka merged commit 6e0f0bf into datacarpentry:main Dec 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Auto-generated via {sandpaper}
Source  : 6e0f0bf
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2023-12-13 16:32:55 +0000
Message : Merge pull request #243 from sstevens2/patch-5

Removing tidyverse install from ggplot lesson
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
Auto-generated via {sandpaper}
Source  : e9727b7
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-12-13 16:36:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 6e0f0bf
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2023-12-13 16:32:55 +0000
Message : Merge pull request #243 from sstevens2/patch-5

Removing tidyverse install from ggplot lesson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inconsistent use of tidyverse in episodes
2 participants