Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor clean up (style/spacing, remove unneeded chunk, etc) #274

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

naupaka
Copy link
Member

@naupaka naupaka commented Apr 10, 2024

Some minor clean up tweaks

Copy link

github-actions bot commented Apr 10, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/genomics-r-intro/compare/md-outputs..md-outputs-PR-274

The following changes were observed in the rendered markdown documents:

 01-r-basics.md                  |  16 +-
 03-basics-factors-dataframes.md |   2 +-
 config.yaml (gone)              |  88 ----
 depth.pdf                       | Bin 45059 -> 45059 bytes
 md5sum.txt                      |  36 +-
 renv.lock (gone)                | 975 ----------------------------------------
 6 files changed, 26 insertions(+), 1091 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-02 15:21:22 +0000

github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@JasonJWilliamsNY
Copy link
Contributor

Looks good

github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@JasonJWilliamsNY JasonJWilliamsNY merged commit a3a27da into datacarpentry:main Oct 2, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Auto-generated via {sandpaper}
Source  : a3a27da
Branch  : main
Author  : Jason Williams <JasonJWilliamsNY@gmail.com>
Time    : 2024-10-02 15:28:06 +0000
Message : Merge pull request #274 from naupaka/main

Some minor clean up (style/spacing, remove unneeded chunk, etc)
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Auto-generated via {sandpaper}
Source  : 1d7f1be
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-02 15:29:14 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a3a27da
Branch  : main
Author  : Jason Williams <JasonJWilliamsNY@gmail.com>
Time    : 2024-10-02 15:28:06 +0000
Message : Merge pull request #274 from naupaka/main

Some minor clean up (style/spacing, remove unneeded chunk, etc)
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
Auto-generated via {sandpaper}
Source  : 1d7f1be
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-10-02 15:29:14 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : a3a27da
Branch  : main
Author  : Jason Williams <JasonJWilliamsNY@gmail.com>
Time    : 2024-10-02 15:28:06 +0000
Message : Merge pull request #274 from naupaka/main

Some minor clean up (style/spacing, remove unneeded chunk, etc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants