Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [DCS-247] add count_all_space and percent_all_space functions #254

Merged

Conversation

Ksaurav3380
Copy link
Contributor

Fixes/Implements

Description

Validity function for count all space and percent all space

Type of change

Delete irrelevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Locally Tested
  • Needs Testing From Production

@Ksaurav3380
Copy link
Contributor Author

fix: module error

dcs_core/core/common/models/validation.py Outdated Show resolved Hide resolved
dcs_core/core/validation/completeness_validation.py Outdated Show resolved Hide resolved
dcs_core/core/datasource/sql_datasource.py Outdated Show resolved Hide resolved
dcs_core/core/validation/completeness_validation.py Outdated Show resolved Hide resolved
add: all space completeness validation

fix: module error

add: all space completeness validation
@Ksaurav3380 Ksaurav3380 force-pushed the all-space-completeness-validation branch from 95c3cec to 6fc683e Compare September 7, 2024 18:48
@subhankarb subhankarb merged commit dd2e29f into datachecks:main Sep 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants