RTBKIT-527 #25
Closed
RTBKIT-527 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't changes to soa be done in the datacratic/soa repo first and then git-subtree'd into this repo? |
|
@nicolaskruchten -- why can commit/push my changes? also last time I had to do something cross repos, I think the one I did on soa was redundant |
|
Actually never mind my comment, turns out there's no reason to prefer one over the other apparently :) That said, I doubt that simply disabling tests in SOA is the right thing to do... |
| @@ -1,5 +1,5 @@ | |||
| CXX ?= g++ | |||
| CXXFLAGS ?= $(INCLUDE) -pipe -Wall -Werror -Wno-sign-compare -Woverloaded-virtual -fPIC -m64 -ggdb -fno-omit-frame-pointer $(foreach dir,$(LOCAL_INCLUDE_DIR),-I$(dir)) -std=c++0x -Wno-deprecated-declarations | |||
| CXXFLAGS ?= $(INCLUDE) -pipe -Wall -Werror -Wno-sign-compare -Woverloaded-virtual -fPIC -m64 -ggdb -fno-omit-frame-pointer $(foreach dir,$(LOCAL_INCLUDE_DIR),-I$(dir)) -Wno-deprecated-declarations | |||
There was a problem hiding this comment.
This is not required. As far as I know, gcc-4.8 still accept -std=c++0x.
There was a problem hiding this comment.
Turns out I was wrong, the later versions of gcc still support the older c++0x which we should keep on using until we fully migrate to gcc4.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR goes along @RTBKIT-527 and relies on datacratic/platform-deps#1
It add support for Ubuntu 14.04(,x) LTS.
Note that the following two tests have been modified i/o pass: