Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement json_object_key (and alias json_keys) #50

Merged
merged 6 commits into from
Oct 28, 2024
Merged

implement json_object_key (and alias json_keys) #50

merged 6 commits into from
Oct 28, 2024

Conversation

samuelcolvin
Copy link
Collaborator

cc @adriangb.

samuelcolvin
samuelcolvin commented Oct 26, 2024
View reviewed changes
src/common.rs Outdated Show resolved Hide resolved
samuelcolvin
samuelcolvin commented Oct 26, 2024
View reviewed changes
src/common_union.rs Outdated Show resolved Hide resolved
@samuelcolvin
Copy link
Collaborator Author

I think this is ready.

adriangb
adriangb approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@adriangb adriangb merged commit 2a7c5b2 into main Oct 28, 2024
7 checks passed
@adriangb adriangb deleted the json_keys branch October 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangb adriangb adriangb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelcolvin @adriangb