Introduce show/hide flags for dataset buttons #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The visibility of dataset buttons have until now depended mostly on inherent logic, such as whether a specific property related to the button is included in the dataset-level metadata or not. This commit introduces controlling flags that users can specify via catalog- or dataset-level config files. These flags can explicitly be set to false if the user prefers to hide specific buttons, while the default for these flags is true (i.e. show the buttons, unless some data-related logic specifies not to). The updated template config file at 'datalad_catalog/config/config.json' contains all new controlling flags. In addition to the code changes to make the above possible, the way in which the 'dataset_options' are set for a selected dataset has been updated. dataset_options should be an object that is a merge between the catalog-level config and the dataset-level config, with dataset-level taking priority.
✅ Deploy Preview for datalad-catalog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visibility of dataset buttons have until now depended mostly on inherent logic, such as whether a specific property related to the button is included in the dataset-level metadata or not. This commit introduces controlling flags that users can specify via catalog- or dataset-level config files. These flags can explicitly be set to false if the user prefers to hide specific buttons, while the default for these flags is true (i.e. show the buttons, unless some data-related logic specifies not to).
The updated template config file at
datalad_catalog/config/config.jsoncontains all new controlling flags.In addition to the code changes to make the above possible, the way in which the
dataset_optionsare set for a selected dataset has been updated.dataset_optionsshould be an object that is a merge between the catalog-level config and the dataset-level config, with dataset-level taking priority.Also adds a flag and display options for gitlab projects, ping #462
Closes #465