Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put lobbyist info on homepage #157

Merged
merged 3 commits into from
Jan 18, 2019
Merged

Put lobbyist info on homepage #157

merged 3 commits into from
Jan 18, 2019

Conversation

evz
Copy link
Contributor

@evz evz commented Jan 17, 2019

NMID asked that we copy the info from the lobbyist page onto the homepage to replace the info on the races in the last election. This PR does that.

Copy link
Member

@hancush hancush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the whole, this makes sense to me! a couple of questions inline, the upshot of which are: should we preserve the code for displaying race data somehow?

camp_fin/views.py Show resolved Hide resolved
@@ -84,7 +84,45 @@ def get_context_data(self, **kwargs):
return context


class IndexView(TopEarnersBase, PagesMixin):
class LobbyistContextMixin(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart!

@evz evz merged commit 0c10f42 into master Jan 18, 2019
@hancush hancush deleted the lobbyist_updates branch September 19, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants