This repository has been archived by the owner on Apr 17, 2018. It is now read-only.
Replace class_eval with method calls in support module #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in the Enum#initialize method, how could this test ever be false? In other words, how could any instance that doesn't inherit from Property::Enum execute the Property::Enum#initialize method?
|
@emmanuel Any chance you could update this against master. If you don't think it's valid anymore I'll close it. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second of 3 pull requests decomposing the many changes in #24. This is a superset of the changes in #30.
These changes replace the use of string-based class_eval with method calls in
Types::Support::FlagsandParanoidBoolean/ParanoidDateTime.