Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipu #525

Merged
merged 17 commits into from
Sep 20, 2024
Merged

Remove ipu #525

merged 17 commits into from
Sep 20, 2024

Conversation

DomInvivo
Copy link
Collaborator

Changelogs

  • Removing support for IPU
  • Removing custom to_dense_batch and to_sparse_batch specific to IPUs, and reverted to the pyg version
  • Removing all documentation regarding IPUs

discussion related to that PR

@DomInvivo DomInvivo changed the base branch from graphium_3.0 to torchmetrics September 9, 2024 18:19
@WenkelF
Copy link
Collaborator

WenkelF commented Sep 11, 2024

@DomInvivo, I have no concerns with the changes. The unit tests might need an overhaul though.

I resolved conflicts in order to run the env checks and they are failing (I believe due to issues with the installation of graphium_cpp).

@DomInvivo DomInvivo merged commit 14b45f4 into torchmetrics Sep 20, 2024
3 of 4 checks passed
@DomInvivo DomInvivo mentioned this pull request Sep 23, 2024
28 tasks
@DomInvivo DomInvivo mentioned this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants