[fix](tablet) protect max_version by meta lock

refer to 21948
dataroaring · Aug 30, 2023 · c4d06d8 · c4d06d8
1 parent 3e33f09
commit c4d06d8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/be/src/olap/snapshot_manager.cpp b/be/src/olap/snapshot_manager.cpp
@@ -459,7 +459,7 @@ Status SnapshotManager::_create_snapshot_files(const TabletSharedPtr& ref_tablet
  }
  *allow_incremental_clone = false;
  } else {
- version = ref_tablet->max_version().second;
+ version = ref_tablet->max_version_unlocked().second;
  *allow_incremental_clone = true;
  }
 

diff --git a/be/src/olap/tablet.h b/be/src/olap/tablet.h
@@ -586,6 +586,7 @@ inline int Tablet::version_count() const {
 }
 
 inline Version Tablet::max_version() const {
+ std::shared_lock rdlock(_meta_lock);
  return _tablet_meta->max_version();
 }
 

diff --git a/be/src/olap/task/engine_publish_version_task.cpp b/be/src/olap/task/engine_publish_version_task.cpp
@@ -124,7 +124,7 @@ Status EnginePublishVersionTask::finish() {
  TabletState tablet_state;
  {
  std::shared_lock rdlock(tablet->get_header_lock());
- max_version = tablet->max_version();
+ max_version = tablet->max_version_unlocked();
  tablet_state = tablet->tablet_state();
  }
  if (tablet_state == TabletState::TABLET_RUNNING &&