Skip to content

Commit

Permalink
[fix](Config): Remove unused config max_connection_scheduler_threads_…
Browse files Browse the repository at this point in the history
…num (apache#24597)
  • Loading branch information
xutaoustc committed Sep 20, 2023
1 parent 67e789e commit e4b551e
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 24 deletions.
8 changes: 0 additions & 8 deletions docs/en/docs/admin-manual/config/fe-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -437,14 +437,6 @@ Default:1024

Maximal number of connections per FE.

#### `max_connection_scheduler_threads_num`

Default:4096

Maximal number of thread in connection-scheduler-pool.

The current strategy is to apply for a separate thread for service when there is a request

#### `check_java_version`

Default:true
Expand Down
8 changes: 0 additions & 8 deletions docs/zh-CN/docs/admin-manual/config/fe-config.md
Original file line number Diff line number Diff line change
Expand Up @@ -437,14 +437,6 @@ FE https 使能标志位,false 表示支持 http,true 表示同时支持 htt

每个 FE 的最大连接数

#### `max_connection_scheduler_threads_num`

默认值:4096

查询请求调度器中的最大线程数。

目前的策略是,有请求过来,就为其单独申请一个线程进行服务

#### `check_java_version`

默认值:true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,6 @@ public class Config extends ConfigBase {
"Maximal number of connections of MySQL server per FE."})
public static int qe_max_connection = 1024;

@ConfField(description = {"MySQL 连接调度线程池的最大线程数。",
"Maximal number of thread in MySQL connection-scheduler-pool."})
public static int max_connection_scheduler_threads_num = 4096;

@ConfField(mutable = true, description = {"Colocate join 每个 instance 的内存 penalty 系数。"
+ "计算方式:`exec_mem_limit / min (query_colocate_join_memory_limit_penalty_factor, instance_num)`",
"Colocate join PlanFragment instance memory limit penalty factor.",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package org.apache.doris.qe;

import org.apache.doris.catalog.Env;
import org.apache.doris.common.Config;
import org.apache.doris.common.ThreadPoolManager;
import org.apache.doris.common.util.DebugUtil;
import org.apache.doris.mysql.privilege.PrivPredicate;
Expand All @@ -32,7 +31,6 @@
import java.util.List;
import java.util.Map;
import java.util.TimerTask;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
Expand All @@ -47,8 +45,6 @@ public class ConnectScheduler {
private final AtomicInteger nextConnectionId;
private final Map<Integer, ConnectContext> connectionMap = Maps.newConcurrentMap();
private final Map<String, AtomicInteger> connByUser = Maps.newConcurrentMap();
private final ExecutorService executor = ThreadPoolManager.newDaemonCacheThreadPool(
Config.max_connection_scheduler_threads_num, "connect-scheduler-pool", true);

// valid trace id -> query id
private final Map<String, TUniqueId> traceId2QueryId = Maps.newConcurrentMap();
Expand Down

0 comments on commit e4b551e

Please sign in to comment.