Issue/247 Duplicate Resources #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check needed to avoid NPE in HAPI code
* Unique constraints implemented as constraint trigger run after insert * Constraint trigger functions use postgres advisory transaction locks to ensure uniqueness checks are not executed in parallel * Transaction isolation level of insert/update operations changed from repeatable read to read committed, enabling dirty reads needed to allow constraint triggers to see inserts/updates executed by parallel running transactions * New integration test to validate parallel create operations via transaction and batch bundles as well as direct POSTs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| void checkDeleteAllowed(int index, Connection connection, Identity identity, Resource oldResource); | ||
| void checkDeleteAllowed(int index, Connection connection, Identity identity, Resource oldResource) |
Check notice
Code scanning / CodeQL
Useless parameter Note
| testCreateDuplicatesParallel(createOperation, createOperation, resourceDaoType, createdResourceMatcher); | ||
| } | ||
|
|
||
| private <R extends Resource> void testCreateDuplicatesParallel(Runnable createOperation1, Runnable createOperation2, |
Check notice
Code scanning / CodeQL
Useless parameter Note test
|
closed to rename branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds check to make sure StructureDefinitions define a base definition
Fixes transaction bundle error message
Code cleanup
Unique constraints implemented as constraint trigger run after insert
Constraint trigger functions use postgres advisory transaction locks to ensure uniqueness checks are not executed in parallel
Transaction isolation level of insert/update operations changed from repeatable read to read committed, enabling dirty reads needed to allow constraint triggers to see inserts/updates executed by parallel running transactions
New integration test to validate parallel create operations via transaction and batch bundles as well as direct POSTs
TODO: Delete queries to cleanup duplicate resources from production DBs
closes #247