Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI #3

Merged
merged 1 commit into from
Mar 2, 2015
Merged

Add CLI #3

merged 1 commit into from
Mar 2, 2015

Conversation

arthurvr
Copy link
Contributor

Ref #2.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad14046 on arthurvr:cli into 8d5e4cf on datetime:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ad14046 on arthurvr:cli into 8d5e4cf on datetime:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4808baa on arthurvr:cli into 8d5e4cf on datetime:master.

@arthurvr
Copy link
Contributor Author

@tunnckoCore ping?

@tunnckoCore
Copy link
Member

Ping-pong.
Cool, thanks!

I'll merge and publish ASAP. :)

@arthurvr
Copy link
Contributor Author

arthurvr commented Mar 2, 2015

I'll merge and publish ASAP. :)

@tunnckoCore friendly ping once again?

@tunnckoCore
Copy link
Member

@arthurvr ooh thanks, mate. I totally forgot. 👍

Wait a bit :)

@tunnckoCore
Copy link
Member

It's okey, but I think it should also handle and other cases.

currentDayNumber('August 07, 2015');
//=> 218

currentDayNumber('August 07, 2016');
//=> 219, cuz' year is leap

currentDayNumber('02/16/2015');
//=> 47

current-day-number 02/16/2015

@arthurvr
Copy link
Contributor Author

arthurvr commented Mar 2, 2015

It's okey, but I think it should also handle and other cases.

Sure. I will update my PR.

@tunnckoCore
Copy link
Member

Hm. But its interesting how to handle August 07, 2016 in cli ;d

@tunnckoCore
Copy link
Member

Okey, great. :)

@arthurvr
Copy link
Contributor Author

arthurvr commented Mar 2, 2015

@arthurvr
Copy link
Contributor Author

arthurvr commented Mar 2, 2015

Hm. But its interesting how to handle August 07, 2016 in cli ;d

What do you mean?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9397d9c on arthurvr:cli into 8d5e4cf on datetime:master.

@tunnckoCore
Copy link
Member

Haha, cool. Looks great.

tunnckoCore added a commit that referenced this pull request Mar 2, 2015
@tunnckoCore tunnckoCore merged commit f64df50 into datetime:master Mar 2, 2015
@arthurvr arthurvr deleted the cli branch March 2, 2015 21:30
@tunnckoCore
Copy link
Member

@arthurvr released and published as v1.0.6
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants