Encode Multiple Timeout Approaches #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits Timeouts for RedisRequest (the time to interact with redis), CommandTimeout (the time for a user to wait for a command to return). Where this is slightly awkward is the fact that on Queued/Cluster you want Command to be shorter than RedisRequest, since they are unrelated. Whereas on Pooled/Direct you want Command to be longer than the request since if you cancel the command it will cancel before that is seen and hence returned to the pool. Since that signal cant be intercepted to prevent its reuse.
Finally we massively tune down the default timeouts. If you are using blocking operations, then you should use different defaults, but in most cases folks use blocking operations less these days in my experience.