Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1 default output not properly set #2

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

davidalpert
Copy link
Owner

No description provided.

enables us to write unit tests to reproduce bugs and
more easily verify refactoring and new features
default output format is sometimes nil
@davidalpert davidalpert force-pushed the GH-1-default-output-format-not-properly-set branch 2 times, most recently from 36c1bd7 to 823f4a1 Compare November 19, 2023 17:56
@davidalpert davidalpert changed the title chore: downgrade module version to go 1.16 fix: #1 default output not properly set Nov 19, 2023
I was setting the wrong property in contradiction with
the logic around default output format

fixes: #1
@davidalpert davidalpert force-pushed the GH-1-default-output-format-not-properly-set branch from 36c1bd7 to 771f65c Compare November 19, 2023 18:02
@davidalpert davidalpert merged commit bf33af5 into main Nov 19, 2023
1 check passed
@davidalpert davidalpert deleted the GH-1-default-output-format-not-properly-set branch November 19, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant