Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: limit make parallelism #335

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

pjonsson
Copy link

@pjonsson pjonsson commented Dec 2, 2024

Build time improves if the number
of compilation procesess aren't
unlimited, so put an upper limit
of the number of cores on the build
machine.

Build time improves if the number
of compilation procesess aren't
unlimited, so put an upper limit
of the number of cores on the build
machine.
@pjonsson
Copy link
Author

@davidfrantz this PR is unrelated to the image upgrade, so it should be possible to merge.

If your CI actions run this code, you should see a reasonable performance improvement of not starting 20+ compilers at the same time since the Github CI runners only have 2-3 cores.

@davidfrantz
Copy link
Owner

thanks @pjonsson.

I think I have misunderstood make's -j option. I thought it would do exactly that

@davidfrantz davidfrantz merged commit 7a30645 into davidfrantz:develop Dec 17, 2024
1 check passed
@pjonsson pjonsson deleted the limit-make-parallelism branch December 17, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants