Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5.0.0 #1205

Closed
wants to merge 88 commits into from

Fix github action

1007154
Select commit
Loading
Failed to load commit list.
Closed

V5.0.0 #1205

Fix github action
1007154
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / ESLint failed Feb 15, 2024 in 4s

4 new alerts including 3 errors

New alerts in code changed by this pull request

  • 3 errors
  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 212 in gruntfile.js

See this annotation in the file changed.

Code scanning / ESLint

Detects "RegExp(variable)", which might allow an attacker to DOS your server with a long-running regular expression. Warning

Found non-literal argument to RegExp Constructor

Check failure on line 108 in src/iframeResizer.contentWindow.js

See this annotation in the file changed.

Code scanning / ESLint

Disallow use of chained assignment expressions Error

Unexpected chained assignment.

Check warning on line 110 in src/iframeResizer.js

See this annotation in the file changed.

Code scanning / ESLint

Disallow the use of `console` Warning

Unexpected console statement.

Check failure on line 608 in src/iframeResizer.js

See this annotation in the file changed.

Code scanning / ESLint

Disallow specified syntax Error

for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.

Check failure on line 608 in src/iframeResizer.js

See this annotation in the file changed.

Code scanning / ESLint

Require `for-in` loops to include an `if` statement Error

The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.

Check failure on line 1082 in src/iframeResizer.js

See this annotation in the file changed.

Code scanning / ESLint

Disallow specified syntax Error

for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.