Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup workflow script #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jmalak
Copy link
Contributor

@jmalak jmalak commented Nov 28, 2024

use new fixed directory names to simplify handling of versions etc.
openssl/(CK_OPENSSL_VERSION) -> openssl/current
zlib/(ZLIB_VERSION) -> zlib/current
libssh/(LIBSSH_VERSION) -> libssh/current
kerberos/kfw -> kerberos/current

Now version variables are used for definition of download URL and for description not for building path etc.

reorder arguments for "run" steps to be more readable

  1. is environment variables setup
  2. working-directory
  3. script
  4. use shell argument as end tag (it is always indented)

fix some download issues and change some url's to be more consistent by example all versions of openssl is downloaded from github openssl release store, not mixed with other sites fix problem with download from sourceforge site for Regina interpreter

use working-directory run argument whenever possible use absolute path for configuration scripts (by example setenv.bat) which doesn't depend on working directory

use bash script if possible to simplify use for cross-compilation

use new fixed directory names to simplify handling of versions etc.
openssl/(CK_OPENSSL_VERSION) -> openssl/current
zlib/(ZLIB_VERSION) -> zlib/current
libssh/(LIBSSH_VERSION) -> libssh/current
kerberos/kfw -> kerberos/current

Now version variables are used for definition of download URL and for description not for building path etc.

reorder arguments for "run" steps to be more readable
1. is environment variables setup
2. working-directory
3. script
4. use shell argument as end tag (it is always indented)

fix some download issues and change some url's to be more consistent
by example all versions of openssl is downloaded from github openssl release store, not mixed with other sites
fix problem with download from sourceforge site for Regina interpreter

use working-directory run argument whenever possible
use absolute path for configuration scripts (by example setenv.bat) which doesn't depend on working directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant