Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/Composer/Composer.php: fix autoloading when analyzing scip-php #159

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

davidrjenni
Copy link
Owner

Since composer 2.6.4 [0], the autoloader suffix reuses the content-hash from the lock file in order to make the builds more reproducible [1]. This lead to a conflict when analyzing scip-php itself when using the Docker container.

[0] https://github.com/composer/composer/releases/tag/2.6.4
[1] composer/composer#11663

Since composer 2.6.4 [0], the autoloader suffix reuses the content-hash
from the lock file in order to make the builds more reproducible [1].
This lead to a conflict when analyzing scip-php itself when using the
Docker container.

[0] https://github.com/composer/composer/releases/tag/2.6.4
[1] composer/composer#11663
@davidrjenni davidrjenni added the bug Something isn't working label Oct 28, 2023
@davidrjenni davidrjenni self-assigned this Oct 28, 2023
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab832c2) 89.63% compared to head (39be99a) 89.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   89.63%   89.66%   +0.02%     
==========================================
  Files          15       15              
  Lines        1042     1045       +3     
==========================================
+ Hits          934      937       +3     
  Misses        108      108              
Files Coverage Δ
src/Composer/Composer.php 90.29% <100.00%> (+0.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidrjenni davidrjenni merged commit 0a65846 into main Oct 28, 2023
8 of 9 checks passed
@davidrjenni davidrjenni deleted the fix-scip-php-autoload branch October 28, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant