Use Node for building assets instead of Java #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great so far! I’ll give it a try on my machine soon and see how it behaves but it looks promising. |
davmillar
approved these changes
Oct 24, 2020
beporter
added a commit
to beporter/DavesMapper
that referenced
this pull request
Oct 25, 2021
Builds on davmillar#91 to add the existing asset pipeline tooling to (only) the vagrant box. This work conflicts with davmillar#90 somewhat. In general, davmillar#90 is preferable as it moves things forward and this PR merely meets the project where it's at. If anything, I'd recommend merging this one first, then adapting davmillar#90 to: 1. Not use yarn. It's unnecessary. 2. Replace yarn.lock with package-lock.json. 3. Remove the unnecessary yui-compressor from the Vagrantfile provisioning block.
beporter
added a commit
to beporter/DavesMapper
that referenced
this pull request
Oct 30, 2021
Builds on davmillar#91 to add the existing asset pipeline tooling to (only) the vagrant box. This work conflicts with davmillar#90 somewhat. In general, davmillar#90 is preferable as it moves things forward and this PR merely meets the project where it's at. If anything, I'd recommend merging this one first, then adapting davmillar#90 to: 1. Not use yarn. It's unnecessary. 2. Replace yarn.lock with package-lock.json. 3. Remove the unnecessary yui-compressor from the Vagrantfile provisioning block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at improving the README file and was trying to decide how to get this up and running. Someone had commented on the prerequisites, so I thought I would try working towards #54 by removing the dependency on Java and yuicompressor.
Since less-css is already a prereq, this has now been included locally via package.json, along with a tool for minifying the JavaScript. While I believe these are working as expected, I can't say for sure until I have the app running. So, it's a bit more dependent on node modules, but no longer dependent on Java.
I haven't included the new built assets or the node_modules folder in this PR because I wanted to get your thoughts on the whole thing first.
Here is the output when running
./build.shwith these changes: