Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.json #1606

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update index.json #1606

wants to merge 2 commits into from
+6 −0

Conversation

Snehaaa18
Copy link

Updated index.json

Description

added description to my file for #quest23

@Snehaaa18 Snehaaa18 requested a review from a team as a code owner December 27, 2024 09:22
Tpuljak
Tpuljak reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also sign your commit with "git commit --amend -s --no-edit && git push -f"

hack/samples/index.json Outdated Show resolved Hide resolved
@Snehaaa18
Update index.json
aaa5dc1 
edited the suggestions
@Tpuljak
Copy link
Member

Tpuljak commented Dec 27, 2024

@Snehaaa18 please add a sign off as per my previous comment

@Snehaaa18
Copy link
Author

Snehaaa18 commented Dec 29, 2024 via email

@Tpuljak
Copy link
Member

Tpuljak commented Dec 29, 2024

@Snehaaa18 you didn't push anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpuljak Tpuljak Tpuljak left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snehaaa18 @Tpuljak