Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.json #1627

Closed
wants to merge 1 commit into from
Closed

Update index.json #1627

wants to merge 1 commit into from

Conversation

Sanyam0101
Copy link

@Sanyam0101 Sanyam0101 commented Dec 28, 2024

my sample

Pull Request Title

Description

Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #X

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

@Sanyam0101 Sanyam0101 requested a review from a team as a code owner December 28, 2024 16:59
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a comma ( , ) at the end of your sample entry.

Also, you need to add a sign off. Try to do it in this PR. Do not raise a new one please.

Copy link
Author

@Sanyam0101 Sanyam0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done changes

hack/samples/index.json Show resolved Hide resolved
@Sanyam0101 Sanyam0101 closed this Dec 28, 2024
@Sanyam0101 Sanyam0101 deleted the patch-3 branch December 28, 2024 18:21
@Sanyam0101 Sanyam0101 restored the patch-3 branch December 28, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants