Add Subclass Tests #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#50](https://github.com/dblock/ruby-enum/pull/50): Add subclass tests - [@coneybeare](https://github.com/coneybeare).Generated by 🚫 Danger |
|
Interesting! I'd love to know what's going on in your project. Care to update rubocop to get a 🍏 build? I'd like to merge the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I came across an issue that I cannot reproduce in the tests, so it must be a difference in the way I load the rails project code, or perhaps in the switch to Zeitwerk loader. None-the-less, here are two tests that show superclass handling is working correctly for values.
I could not reproduce on the latest version of ruby (
3.3.4at the time of this PR)