-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatch capability #95
base: master
Are you sure you want to change the base?
Conversation
First, great to see a complete feature PRed! Excited to get this merged. The things I like is that it just automatically matches players. But I don't love the fact that it forces this to be a doubles game or that the language doesn't match What do you think? Plus:
I'll make some comments inline. |
@@ -1,5 +1,6 @@ | |||
### Changelog | |||
|
|||
* Added automatch support for doubles matches - [@amikula](https://github.com/amikula). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link the PR, like below.
Thanks for all the great comments! I'll work on it...really looking forward to getting this in. Unfortunately, this past weekend when I loaded the code onto a different computer, I can't get the test suite to run successfully. Looks like DatabaseCleaner isn't working properly for some reason I can't ascertain. I guess that will have to be a different pull request once I get to the bottom of it. :-P |
Happy to help! Post your detailed issues here. |
Bump @amikula, I believe your DatabaseCleaner issue is fixed, they released a newer version that works with newer MongoDBs. |
For doubles games, you have to wait for enough players to join and you also have to come up with a fair match. The
automatch
command takes care of both. By default, automatch will be on for 5 minutes, but users can specify an end time or a duration. See README.md for details.