Prevent different workflows starting with the same ID #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
reviewed
Jan 21, 2025
This reverts commit b7541e6.
kraftp
reviewed
Jan 22, 2025
Co-authored-by: Peter Kraft <peter.kraft@dbos.dev> Signed-off-by: Qian Li <liqian.cs@gmail.com>
qianl15
commented
Jan 22, 2025
| const logger = this.executor!.logger; | ||
| try { | ||
| // This combination uniquely identifies a message for a given Kafka cluster | ||
| const workflowUUID = `kafka-unique-id-${topic}-${partition}-${consumerConfig.groupId}-${message.offset}` |
There was a problem hiding this comment.
@chuck-dbos I added error handling and included consumer group ID in the workflow ID. The test seems to pass now. But maybe you have a better solution for this issue.
There was a problem hiding this comment.
This is a good and necessary change. Like Chuck said, we need a better way of generating default consumer group IDs, but that's a separate PR.
kraftp
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #725 where duplicate workflow ID breaks the existing workflow. The solution is to check the recorded function name, class name, and config name (if any) before proceeding to start the workflow. If there's any difference, throw a
DBOSConflictingWorkflowErrorwith a clear error message.This PR also checks the recorded input versus the provided input, and the provided queue name versus the original queue name, and print a warning message if they don't match.