-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize when loaded_at_field is explicitly set to null #10065
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10065 +/- ##
==========================================
- Coverage 88.22% 88.17% -0.06%
==========================================
Files 181 181
Lines 22643 22722 +79
==========================================
+ Hits 19976 20034 +58
- Misses 2667 2688 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6364862
to
0c2e94d
Compare
683785d
to
797bee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
resolves #9320
Problem
When
loaded_at_field
is explicitly set tonull
at the table level, it does not override the source level setting.Solution
Add logic to recognize when the field is set vs unset.
Checklist