Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement state:modified for saved queries #10295

Merged
merged 7 commits into from
Jun 18, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jun 11, 2024

resolves #10294

Problem

Doing state:modified for saved queries didn't work.

Solution

Implement state:modified for saved queries.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner June 11, 2024 18:39
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (c5be8e2) to head (c915283).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10295      +/-   ##
==========================================
+ Coverage   88.72%   88.78%   +0.05%     
==========================================
  Files         180      180              
  Lines       22497    22490       -7     
==========================================
+ Hits        19961    19967       +6     
+ Misses       2536     2523      -13     
Flag Coverage Δ
integration 86.04% <100.00%> (+0.05%) ⬆️
unit 62.19% <100.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Jun 12, 2024
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for fixing it 🙂

Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Two things that are not blocker:

  • is it possible to unit test this change?
  • should we consider move this select modified test to the test for list command and use the new happy path fixture to test it? You can create a follow up ticket and give it to me.

Oh and another thing is if we want to list modified semantic model and metrics, do we need to do similar change? CC @aliceliu since she is working on something related

@gshank
Copy link
Contributor Author

gshank commented Jun 12, 2024

I think that semantic_models and metrics are already listable. What is Alice working on?

@gshank
Copy link
Contributor Author

gshank commented Jun 12, 2024

@ChenyuLInx I'll add some unit tests. As far as a functional test, it's really a selection thing, not precisely list (though they certainly overlap). Will look at what gets into the happy path tests...

@gshank gshank merged commit 71a8a41 into main Jun 18, 2024
63 checks passed
@gshank gshank deleted the saved_query_state_modified branch June 18, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saved queries are not included in the "modified" selector
3 participants