Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy first] move non-circular import to top of manifest.py #10333

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jun 18, 2024

resolves #N/A

Problem

Nested import assuming a cycle

Solution

Move import to top of file since there is no cycle!

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@MichelleArk MichelleArk added the tidy_first "Tidy First" incremental cleanup changes label Jun 18, 2024
@cla-bot cla-bot bot added the cla:yes label Jun 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (71a8a41) to head (fa6e0ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10333   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         180      180           
  Lines       22490    22490           
=======================================
  Hits        19980    19980           
  Misses       2510     2510           
Flag Coverage Δ
integration 86.21% <100.00%> (+0.02%) ⬆️
unit 62.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jun 18, 2024
@MichelleArk MichelleArk marked this pull request as ready for review June 18, 2024 20:08
@MichelleArk MichelleArk requested a review from a team as a code owner June 18, 2024 20:08
@MichelleArk MichelleArk merged commit 0fdc83a into main Jun 18, 2024
78 of 81 checks passed
@MichelleArk MichelleArk deleted the tidy/move-exception-import-to-top branch June 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants