Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tidy first] remove unreachable MacroManifest building methods #10409

Closed
wants to merge 1 commit into from

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 5, 2024

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

sanity test search: https://github.com/search?q=org%3Adbt-labs%20create_macro_manifest&type=code

@cla-bot cla-bot bot added the cla:yes label Jul 5, 2024
@MichelleArk MichelleArk added tidy_first "Tidy First" incremental cleanup changes and removed cla:yes labels Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant