-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable setting datetime value for dbt_valid_to when the record is current #10780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10780 +/- ##
==========================================
- Coverage 89.20% 89.18% -0.03%
==========================================
Files 183 183
Lines 23419 23426 +7
==========================================
+ Hits 20892 20893 +1
- Misses 2527 2533 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Sep 27, 2024
peterallenwebb
approved these changes
Oct 1, 2024
Reminder, we need to unpin the dependency branches before merge. Otherwise this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10187
Problem
Currently we use a null to indicate that a snapshot record is current. Users would like to use some arbitrary future date to indicate current instead, because it makes some SQL easier.
Solution
Add a new attribute "dbt_valid_to_current", and implement changes in adapters to use it.
Checklist