Improve performance of infer primary key #10782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10782 +/- ##
==========================================
- Coverage 89.04% 88.98% -0.06%
==========================================
Files 181 181
Lines 23115 23126 +11
==========================================
- Hits 20583 20579 -4
- Misses 2532 2547 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ChenyuLInx
approved these changes
Sep 25, 2024
| for node in self.manifest.nodes.values(): | ||
| if not isinstance(node, ModelNode): | ||
| continue | ||
| generic_tests = self._get_generic_tests_for_model(node) | ||
| if node.created_at < self.started_at: |
There was a problem hiding this comment.
Why we can continue here because this node is from partial parting which means it didn't change? maybe a short comment?
There was a problem hiding this comment.
Yes, because it hasn't changed on this parse. That equivalent line occurs in 19 other places, so I'm not going to bother documenting it here :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10781
Problem
Poor performance of inferring primary key.
Solution
Do not process primary keys for unchanged models. When inferring a primary key, start by making a map of models to generic tests.
Checklist