state:modified vars, behind "state_modified_compare_vars" behaviour flag #10793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichelleArk
added
the
artifact_minor_upgrade
MichelleArk
changed the title
MichelleArk
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10793 +/- ##
==========================================
+ Coverage 89.16% 89.20% +0.04%
==========================================
Files 183 183
Lines 23258 23344 +86
==========================================
+ Hits 20738 20825 +87
+ Misses 2520 2519 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Associated schemas PR: dbt-labs/schemas.getdbt.com#64 |
MichelleArk
requested review from
wpowers-dbt
and removed request for
a team
gshank
approved these changes
Sep 30, 2024
MichelleArk
commented
Sep 30, 2024
| @@ -58,19 +70,21 @@ def __call__(self, var_name, default=Var._VAR_NOTSET): | |||
| all_vars.add(my_config.vars.vars_for(lookup, adapter_type)) | |||
| all_vars.add(active_vars) | |||
|
|
|||
| if var_name in all_vars: | |||
| return all_vars[var_name] | |||
| if not var_found and var_name in all_vars: | |||
There was a problem hiding this comment.
This refactor was primarily for the happiness of our linting tools. There was no final return statement on the method in the past.
aranke
added a commit
that referenced
this pull request
Oct 2, 2024
aranke
added a commit
that referenced
this pull request
Oct 2, 2024
QMalcolm
added a commit
to dbt-labs/schemas.getdbt.com
that referenced
this pull request
Oct 12, 2024
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
QMalcolm
added a commit
to dbt-labs/schemas.getdbt.com
that referenced
this pull request
Oct 15, 2024
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
QMalcolm
added a commit
to dbt-labs/schemas.getdbt.com
that referenced
this pull request
Oct 15, 2024
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4304
Problem
With #10675, we removed the capability for dbt to (sometimes) detect changes in vars as modifying models/dbt resources that depended on them (behind a behaviour flag).
Solution
This behaviour is actually desired (distinction between env_var and var), so let's introduce state:modified.vars as a standalone selector method as well as a default. This is also behind a behaviour flag in case existing users rely on the current var state:modified selection behaviour (flawed as it is!).
Checklist