-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple unique keys in snapshots #10795
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10795 +/- ##
==========================================
- Coverage 89.15% 89.13% -0.02%
==========================================
Files 183 183
Lines 23443 23443
==========================================
- Hits 20901 20897 -4
- Misses 2542 2546 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
peterallenwebb
approved these changes
Oct 1, 2024
This was referenced Oct 23, 2024
QMalcolm
added a commit
to dbt-labs/schemas.getdbt.com
that referenced
this pull request
Oct 23, 2024
QMalcolm
added a commit
to dbt-labs/schemas.getdbt.com
that referenced
this pull request
Oct 23, 2024
* Update default `lookback` value in v12 manifest * Add snapshot changes from dbt-labs/dbt-core#10795
QMalcolm
pushed a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9992
Problem
Users may want to snapshot tables with multiple unique keys.
Solution
Redefine the SnapshotConfig unique_key attribute as a Optional[Union[str, List[str]]]. Supporting code in dbt-adapters.
Checklist