Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dbt_valid_to_current test (will go in adapter zone) #10854

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Oct 15, 2024

Resolves #

Problem

Order of syncing code causing issues.

Solution

This test will go in the adapter zone, removing from here for now

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Oct 15, 2024
@gshank gshank requested a review from a team as a code owner October 15, 2024 18:54
@cla-bot cla-bot bot added the cla:yes label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (cd6bb9e) to head (3d84f3c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10854      +/-   ##
==========================================
- Coverage   89.13%   89.11%   -0.02%     
==========================================
  Files         183      183              
  Lines       23434    23434              
==========================================
- Hits        20887    20883       -4     
- Misses       2547     2551       +4     
Flag Coverage Δ
integration 86.35% <ø> (-0.02%) ⬇️
unit 62.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.11% <ø> (ø)
Integration Tests 86.35% <ø> (-0.02%) ⬇️

@gshank gshank merged commit 8f84716 into main Oct 15, 2024
65 checks passed
@gshank gshank deleted the remove_valid_to_test branch October 15, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants