Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed comment util.py #8222

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

d-kaneshiro
Copy link
Contributor

@d-kaneshiro d-kaneshiro commented Jul 27, 2023

resolves # None

Issue is not created because it corresponds to the following cases.

Exception to this rule: If you’re just opening a PR for a cosmetic fix, such as a typo in documentation, an issue isn’t needed.

https://docs.getdbt.com/community/resources/oss-expectations

Problem

There is a possibility of executing the wrong command when using the dbt command in pytest.

Solution

Fixed the comment to run correctly.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #8222 (fc11bc5) into main (f637092) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8222      +/-   ##
==========================================
- Coverage   86.23%   86.22%   -0.01%     
==========================================
  Files         174      174              
  Lines       25518    25518              
==========================================
- Hits        22005    22004       -1     
- Misses       3513     3514       +1     
Files Changed Coverage Δ
core/dbt/tests/util.py 86.57% <ø> (ø)

... and 1 file with indirect coverage changes

@d-kaneshiro d-kaneshiro marked this pull request as ready for review July 27, 2023 08:12
@d-kaneshiro d-kaneshiro requested a review from a team as a code owner July 27, 2023 08:12
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Jul 28, 2023
@emmyoop
Copy link
Member

emmyoop commented Jul 28, 2023

@d-kaneshiro can you please rebase this off main? We made some CI improvements to split up our integration tests to run faster. Unfortunately it means you'll need to pull main in to get all your checks passing.

@d-kaneshiro
Copy link
Contributor Author

d-kaneshiro commented Jul 31, 2023

@emmyoop
thanks for the review.
I pulled in the latest main branch. But automated testing with CI fails.
Since I don't know the cause, could you tell me what to do next?

@emmyoop
Copy link
Member

emmyoop commented Jul 31, 2023

@d-kaneshiro I'm looking into what's happening here. This is something we will probably need to fix.

@emmyoop
Copy link
Member

emmyoop commented Jul 31, 2023

@d-kaneshiro if you could rebase off main one more time CI should run and pass!

@d-kaneshiro
Copy link
Contributor Author

d-kaneshiro commented Aug 4, 2023

@emmyoop

if you could rebase off main one more time CI should run and pass!

Thank you.
I rebased the commits up to #f637092.(This is the latest version of main at the moment)
However, I am getting an error in Codecov Report.
This is an error due to a place unrelated to my changes.

@gshank gshank merged commit 506f65e into dbt-labs:main Aug 9, 2023
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants