Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test matrix #943

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

Problem

Matrix strategy entries need to be arrays, even when there is only one value, but we left it as the value itself.

Solution

Wrap the single value in [].

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare requested a review from a team as a code owner November 6, 2024 22:15
@mikealfare mikealfare self-assigned this Nov 6, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 6, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@mikealfare
Copy link
Contributor Author

@mikealfare mikealfare merged commit 1943ac5 into main Nov 6, 2024
45 of 48 checks passed
@mikealfare mikealfare deleted the fix-integration-test-matrix branch November 6, 2024 23:34
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

(cherry picked from commit d024eaf)

* test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942)

(cherry picked from commit fa4d72c)

* matrix entries need to be an array, even with only one value (#943)

(cherry picked from commit 1943ac5)

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

* move github runner from macos-12 to macos-14

(cherry picked from commit d024eaf)

* update test matrix

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941)

* move github runner from macos-12 to macos-14

(cherry picked from commit d024eaf)

* update test matrix

---------

Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants