-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration test matrix #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
added
Skip Changelog
Skips GHA to check for changelog file
and removed
cla:yes
labels
Nov 6, 2024
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
colin-rogers-dbt
approved these changes
Nov 6, 2024
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1943ac5)
This was referenced Nov 8, 2024
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1943ac5)
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1943ac5)
This was referenced Nov 8, 2024
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941) (cherry picked from commit d024eaf) * test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942) (cherry picked from commit fa4d72c) * matrix entries need to be an array, even with only one value (#943) (cherry picked from commit 1943ac5) --------- Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941) (cherry picked from commit d024eaf) * test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942) (cherry picked from commit fa4d72c) * matrix entries need to be an array, even with only one value (#943) (cherry picked from commit 1943ac5) --------- Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
mikealfare
added a commit
that referenced
this pull request
Nov 8, 2024
* move github runner from macos-12 to macos-14 (#941) (cherry picked from commit d024eaf) * test macos-14 on py310 instead of py39 due to missing psycopg2-binary (#942) (cherry picked from commit fa4d72c) * matrix entries need to be an array, even with only one value (#943) (cherry picked from commit 1943ac5) --------- Co-authored-by: Colin Rogers <111200756+colin-rogers-dbt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Matrix strategy entries need to be arrays, even when there is only one value, but we left it as the value itself.
Solution
Wrap the single value in
[]
.Checklist