Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser IDC authentication method #950

Merged
merged 13 commits into from
Nov 25, 2024
Merged

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Nov 14, 2024

partially completes #898

Problem

We want to add additional authentication methods using IAM Identity Center for Redshift.

Solution

This Pull request completes one requirement by adding the browser-based authentication method.

I've refactored the code to be purely functional and assemble parameters in a tail-recursive fashion so the code reflects a gradual build up of reusable chunks.

Along with this PR is a lot of research and experimentation in Redshift/Iam to get a model to build on Redshift using this method!

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 14, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@VersusFacit
Copy link
Contributor Author

VersusFacit commented Nov 19, 2024

I figured out the browser setup 🚀 Can't be automated really but this along with the unit tests tells me the browser method is good to go engineering wise. We are waiting on some product experience review notes from Amy though.

image
image

@VersusFacit VersusFacit changed the title Add authentication methods and unit tests. Add browser IDC authentication method Nov 22, 2024
@VersusFacit VersusFacit self-assigned this Nov 22, 2024
@VersusFacit VersusFacit marked this pull request as ready for review November 22, 2024 22:33
@VersusFacit VersusFacit requested a review from a team as a code owner November 22, 2024 22:33
@VersusFacit
Copy link
Contributor Author

Latest pushed sha re-confirmed builds a model correctly 👍

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, nothing blocking. I like the refactor to a more functional approach.

setup.py Outdated Show resolved Hide resolved
dbt/adapters/redshift/connections.py Outdated Show resolved Hide resolved
dbt/adapters/redshift/connections.py Outdated Show resolved Hide resolved
dbt/adapters/redshift/connections.py Outdated Show resolved Hide resolved
dbt/adapters/redshift/connections.py Show resolved Hide resolved
@VersusFacit VersusFacit reopened this Nov 23, 2024
@VersusFacit
Copy link
Contributor Author

@cla-bot check

@mikealfare
Copy link
Contributor

CLA-bot is not working at the moment. The PR author is a dbt Labs employee, hence has signed the CLA. Merging with manual verification.

@mikealfare mikealfare merged commit c457faf into main Nov 25, 2024
62 checks passed
@mikealfare mikealfare deleted the ADAP-898/add_iam_authentication branch November 25, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants