-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making breadcrumbs clickable #3515
Conversation
❌ Deploy Preview for docs-getdbt-com failed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sections without a landing page (Some of these might be best addressed in a follow up PR):
- https://docs-getdbt-com-git-sidebar-dbt-labs.vercel.app/docs/dbt-cloud-apis/discovery-schema-environment-applied-modelHistoricalRuns
- (Address in a follow up PR) All folders under Release notes: https://docs-getdbt-com-git-sidebar-dbt-labs.vercel.app/docs/dbt-versions/release-notes/Sept-2023/removing-prerelease-versions
- (Address in a follow up PR) All folders under FAQs
Otherwise this all looks good!
We'll address in a future (post-coalesce) PR. Not every section has a proper landing page, so to keep the experience consistent across the menu, it just links to the first page in that section. It'll be highlighted on the nav bar so the user will be able to visualize where they are. |
@matthewshaver : added the "card" landing pages per our conversation. please take a look and lemme know what you think! there are a few that i left alone:
|
Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mirna is at coalecse conf. ly and matt worked together to get this to the finish line
What are you changing in this pull request and why?
Making the breadcrumb trail items in the docs pages clickable. Many of them are now, but the categories that don't have links are static and unable to be used for navigation.
Based on customer feedback, our readers would like to be able to click on all items in the breadcrumb trail to make navigation through the pages easier.
This will add links to the categories that don't have them by leveraging existing
About...
pages or creating new ones where required. To keep a consistent navigational experience, we will make the links available as pages in the menu as well.Checklist
Adding new pages (delete if not applicable):
website/sidebars.js
Removing or renaming existing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects