Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making breadcrumbs clickable #3515

Merged
merged 23 commits into from
Oct 17, 2023
Merged

Making breadcrumbs clickable #3515

merged 23 commits into from
Oct 17, 2023

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Making the breadcrumb trail items in the docs pages clickable. Many of them are now, but the categories that don't have links are static and unable to be used for navigation.

Based on customer feedback, our readers would like to be able to click on all items in the breadcrumb trail to make navigation through the pages easier.

This will add links to the categories that don't have them by leveraging existing About... pages or creating new ones where required. To keep a consistent navigational experience, we will make the links available as pages in the menu as well.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@matthewshaver matthewshaver requested a review from a team as a code owner June 13, 2023 14:57
@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for docs-getdbt-com failed.

Name Link
🔨 Latest commit 6bfd29b
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64b94927042602000716de60

@github-actions github-actions bot added the content Improvements or additions to content label Jun 13, 2023
@matthewshaver matthewshaver marked this pull request as draft June 13, 2023 14:57
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Jun 13, 2023
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Jul 5, 2023
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 0:51am

@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Oct 3, 2023
@matthewshaver matthewshaver marked this pull request as ready for review October 5, 2023 19:29
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sections without a landing page (Some of these might be best addressed in a follow up PR):

Otherwise this all looks good!

website/static/_redirects Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size: medium This change will take up to a week to address label Oct 12, 2023
@matthewshaver
Copy link
Contributor Author

Visit Preview

We'll address in a future (post-coalesce) PR. Not every section has a proper landing page, so to keep the experience consistent across the menu, it just links to the first page in that section. It'll be highlighted on the nav bar so the user will be able to visualize where they are.

@github-actions github-actions bot added size: large This change will more than a week to address and might require more than one person and removed size: medium This change will take up to a week to address labels Oct 16, 2023
@nghi-ly
Copy link
Contributor

nghi-ly commented Oct 16, 2023

@matthewshaver : added the "card" landing pages per our conversation. please take a look and lemme know what you think!

there are a few that i left alone:

Co-authored-by: Matt Shaver <60105315+matthewshaver@users.noreply.github.com>
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nghi-ly nghi-ly dismissed mirnawong1’s stale review October 17, 2023 00:55

mirna is at coalecse conf. ly and matt worked together to get this to the finish line

@matthewshaver matthewshaver merged commit c915480 into current Oct 17, 2023
7 checks passed
@matthewshaver matthewshaver deleted the sidebar branch October 17, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants