Community Spotlight Members Round 2 #3751
Conversation
✅ Deploy Preview for docs-getdbt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content
JKarlavige
requested review from
a team,
breezyfasano,
lfracalossiFA and
amada-ech
and removed request for
a team
| @@ -100,7 +100,7 @@ function CommunitySpotlightCard({ frontMatter, isSpotlightMember = false }) { | |||
| </div> | |||
| )} | |||
| {description && !isSpotlightMember && ( | |||
| <p className={styles.spotlightMemberDescription}>{truncateText(description)}</p> | |||
| <p className={styles.spotlightMemberDescription} dangerouslySetInnerHTML={{__html: truncateText(description)}} /> | |||
There was a problem hiding this comment.
Ruh-roh, dangerouslySetInnerHtml! 😆 I'm sure it's fine, but just for my own curiosity: what's this change for?
There was a problem hiding this comment.
This is to support html links within the description field on the cards within the spotlight index page. Doing the same for the description on individual spotlight member pages.
website/src/components/communitySpotlightCard/styles.module.css
Outdated
Show resolved
Hide resolved
| // This date determines where the 'Previously on the Spotlight" text will show. | ||
| // Any spotlight members with a 'dateCreated' field before this date | ||
| // will be under the 'Previously..' header. | ||
| const currentSpotlightDate = new Date('2023-06-01') |
There was a problem hiding this comment.
Will this need to be updated manually whenever we do a new spotlight?
There was a problem hiding this comment.
Yeah since we're using the dateCreated field we're using this to know where to show the Previously header
|
No required changes; just a couple of clarifying questions. |
| // Otherwise href, title, rel values all counted as text. | ||
| if(hasLinks) { | ||
| const linkText = str.match(/(?<=<a ).*(?=<\/a>)/g) | ||
| if(linkText?.length && linkText[0]?.length) { |
There was a problem hiding this comment.
this is neat!! i hate regex but i love regex!
Asana
What are you changing in this pull request and why?
This adds the latest addition of Community Spotlight Members. Adjustments to the
communitySpotlightCardandcommunitySpotlightListcomponents were made to support showing aPreviously on the spotlightheader for older spotlight members.Previews
https://deploy-preview-3751--docs-getdbt-com.netlify.app/community/spotlight
https://deploy-preview-3751--docs-getdbt-com.netlify.app/community/spotlight/josh-devlin