Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Js add specs and cli docs #3771

Merged
merged 20 commits into from
Jul 20, 2023
Merged

Js add specs and cli docs #3771

merged 20 commits into from
Jul 20, 2023

Conversation

Jstein77
Copy link
Contributor

What are you changing in this pull request and why?

Adding additional generic example to metrics and measures docs.

@Jstein77 Jstein77 requested a review from a team as a code owner July 19, 2023 03:07
@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person labels Jul 19, 2023
@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit 81d305a
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64b9585b6d6ee5000839feeb
😎 Deploy Preview https://deploy-preview-3771--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


## Installation
1. Create or activate your virtual environment.`python -m venv venv`
2. Run `pip install dbt-metricflow`
Copy link
Contributor

@mirnawong1 mirnawong1 Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jstein77 is it pip install dbt-metricflow or pip install metricflow per the readme?
also what python versions are supported? the metricflow github repo says requires-python = ">=3.8,<3.12" but my error seems to imply it doesn't support 3.11, which I'm on?

I'm on python 3.11.4, so when i tried installing using dbt-metricflow, i got the below error:

(mwong-metrics) ➜  ~ git:(current) ✗ pip install dbt-metricflow
ERROR: Ignored the following versions that require a different python version: 0.0.1 Requires-Python <3.10,>=3.8; 0.0.2 Requires-Python <3.10,>=3.8; 0.0.3 Requires-Python <3.10,>=3.8
ERROR: Could not find a version that satisfies the requirement dbt-metricflow (from versions: none)
ERROR: No matching distribution found for dbt-metricflow

but when i used pip install metricflow as specified in the cli package github readme, it installed successfully.

Screenshot 2023-07-19 at 10 08 54

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bug. The preferred way to install the cli is pip install dbt-metricflow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt-labs/metricflow#663 should be resolved when this is merged

@mirnawong1 mirnawong1 mentioned this pull request Jul 19, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 changed the title Js add specs Js add specs and cli docs Jul 19, 2023
The MetricFlow CLI is compatible with Python versions 3.8, 3.9, 3.10 and 3.11

# CLI commands

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No description provided.

@mirnawong1
Copy link
Contributor

let me know if you want me to merge @Jstein77 !

@Jstein77 Jstein77 enabled auto-merge July 20, 2023 15:53
@Jstein77 Jstein77 merged commit 4386b9c into current Jul 20, 2023
10 checks passed
@Jstein77 Jstein77 deleted the js-add-specs branch July 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants