Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metricflow-time-spine.md #3783

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Update metricflow-time-spine.md #3783

merged 6 commits into from
Jul 24, 2023

Conversation

dave-connors-3
Copy link
Contributor

What are you changing in this pull request and why?

metricflow requires the time spine model to be materialized as a table. Updating the example code to include the required config.

@dave-connors-3 dave-connors-3 requested a review from a team as a code owner July 20, 2023 15:17
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit dfa92b1
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64be637beddd050008a617e1
😎 Deploy Preview https://deploy-preview-3783--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jul 20, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 @dave-connors-3 ! thank you so much for opening it up!

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jul 20, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging this for you @dave-connors-3 ! ✨

@mirnawong1 mirnawong1 merged commit 6b3ec20 into current Jul 24, 2023
10 checks passed
@mirnawong1 mirnawong1 deleted the dave-connors-3-patch-1 branch July 24, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants