Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2-staging.md #3785

Closed
wants to merge 8 commits into from
Closed

Update 2-staging.md #3785

wants to merge 8 commits into from

Conversation

chekos
Copy link

@chekos chekos commented Jul 20, 2023

What are you changing in this pull request and why?

Noticed a typo while reading this guide

Typo/order mixed up
@chekos chekos requested a review from a team as a code owner July 20, 2023 16:52
@welcome
Copy link

welcome bot commented Jul 20, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit f324dcf
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/64e74ec5f02b790008312a16
😎 Deploy Preview https://deploy-preview-3785--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Jul 20, 2023
@runleonarun
Copy link
Collaborator

@joellabes This looks good to me! Should I merge?

@joellabes
Copy link
Contributor

@chekos can you clarify why you think this is a typo?

Your suggested change would materialize models in the staging project under the jaffle_shop subdirectory as views, which isn't correct.

@mirnawong1
Copy link
Contributor

it also seems to go against this doc and example. this example is for the project.yml file, not your file tree -- did you think this was the file tree folder @chekos ?

@mirnawong1
Copy link
Contributor

hey @chekos , checking on this. i'll go ahead and close this pr but if you have strong opinions, please feel free to re-open it or open a new one 🙏

@mirnawong1 mirnawong1 closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants