Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docs for quota project #6054

Draft
wants to merge 7 commits into
base: current
Choose a base branch
from

Conversation

jcarpenter12
Copy link

@jcarpenter12 jcarpenter12 commented Sep 11, 2024

What are you changing in this pull request and why?

References dbt-labs/dbt-bigquery#1343 dbt-labs/dbt-bigquery#1344

Adding docs to detail changes in PR dbt-labs/dbt-bigquery#1345

This adds detail about how to override the quota_project through the dbt profile. It also updates the information regarding the execution project. I believe that the execution project just sets where the BQ job is created and doesn't actually impact where it's billed from (I could be wrong on this, but from my testing I can see that the quota project is set from the environment not from the execution project override currently detailed in the docs).

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Copy link

welcome bot commented Sep 11, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Sep 11, 2024

@jcarpenter12 is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Sep 11, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Sep 11, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Sep 11, 2024
@jcarpenter12 jcarpenter12 marked this pull request as ready for review September 11, 2024 23:58
@jcarpenter12 jcarpenter12 requested a review from a team as a code owner September 11, 2024 23:58
@jcarpenter12
Copy link
Author

Please see the two issues referenced in the details for context on this

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 19, 2024 2:36pm

Copy link
Contributor

@matthewshaver matthewshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jcarpenter12 !

@matthewshaver
Copy link
Contributor

Putting on hold in draft. Can merge when dbt-labs/dbt-bigquery#1345 is complete

@matthewshaver matthewshaver marked this pull request as draft September 19, 2024 15:56
@jcarpenter12
Copy link
Author

Putting on hold in draft. Can merge when dbt-labs/dbt-bigquery#1345 is complete

Thanks @matthewshaver for taking a look at this, much appreciated!

@mikealfare
Copy link
Contributor

We should add that the Service Usage Consumer role is required to use this feature. Everything else works fine if quota_project is not provided. However if this is provided and the dbt service account does not have this role on the quota project, an error is raised.

@jcarpenter12
Copy link
Author

We should add that the Service Usage Consumer role is required to use this feature. Everything else works fine if quota_project is not provided. However if this is provided and the dbt service account does not have this role on the quota project, an error is raised.

@mikealfare have updated this PR now to add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants