Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New behavior changes: state_modified_compare_more_unrendered and skip_nodes_if_on_run_start_fails #6204

Merged
merged 22 commits into from
Oct 3, 2024
Merged

New behavior changes: state_modified_compare_more_unrendered and skip_nodes_if_on_run_start_fails #6204

merged 22 commits into from
Oct 3, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Oct 1, 2024 •
edited by runleonarun
Loading

What are you changing in this pull request and why?

Closes #6172
Closes #6185

Preview of behavior changes page

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner October 1, 2024 22:00
@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Oct 3, 2024 5:07pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Oct 1, 2024
matthewshaver
matthewshaver commented Oct 1, 2024
View reviewed changes
website/docs/reference/global-configs/behavior-changes.md Outdated
@@ -68,6 +68,7 @@ When we use dbt Cloud in the following table, we're referring to accounts that h
| require_resource_names_without_spaces | 2024.05.146 | TBD* | 1.8.0 | 1.9.0 |
| source_freshness_run_project_hooks | 2024.03.61 | TBD* | 1.8.0 | 1.9.0 |
| [Redshift] [restrict_direct_pg_catalog_access](#redshift-restrict_direct_pg_catalog_access) | 2024.09.242 | TBD* | dbt-redshift v1.9.0 | 1.9.0 |
| skip_nodes_if_on_run_start_fails | | TBD* | 1.9.0 | TBD* |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 or @graciegoheen, what should be the value for Cloud Intro here?

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 1, 2024
@matthewshaver matthewshaver changed the title on run start behavior change New behavior changes Oct 1, 2024
matthewshaver
matthewshaver commented Oct 1, 2024
View reviewed changes
website/docs/reference/global-configs/behavior-changes.md Outdated
@@ -68,6 +68,8 @@ When we use dbt Cloud in the following table, we're referring to accounts that h
| require_resource_names_without_spaces | 2024.05.146 | TBD* | 1.8.0 | 1.9.0 |
| source_freshness_run_project_hooks | 2024.03.61 | TBD* | 1.8.0 | 1.9.0 |
| [Redshift] [restrict_direct_pg_catalog_access](#redshift-restrict_direct_pg_catalog_access) | 2024.09.242 | TBD* | dbt-redshift v1.9.0 | 1.9.0 |
| skip_nodes_if_on_run_start_fails | | TBD* | 1.9.0 | TBD* |
| state_modified_compare_more_unrendered | | TBD* | 1.9.0 | TBD* |
Copy link
Contributor Author

@matthewshaver matthewshaver Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 and @graciegoheen same for the state modified changes

@graciegoheen
Copy link
Collaborator

@matthewshaver - looks like we have a little section for each behavior change flag on this page to give a quick overview of what it is/what it does - can we add that for these new flags?

runleonarun
runleonarun reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove this line too!

website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
@dbeatty10 @runleonarun
Removing until state_modified_compare_vars is shipped and available
44dd028 
Co-authored-by: Leona B. Campbell <3880403+runleonarun@users.noreply.github.com>
@dbeatty10 dbeatty10 mentioned this pull request Oct 3, 2024
Merged
1 task
matthewshaver pushed a commit that referenced this pull request Oct 3, 2024
@dbeatty10
Remove the patch level from dbt Cloud version numbers (#6232)
af60e0d 
[Preview](https://docs-getdbt-com-git-dbeatty10-patch-3-dbt-labs.vercel.app/reference/global-configs/behavior-changes#behavior-change-flags)

## What are you changing in this pull request and why?

These changes were originally in
#6204, but easier to
code review by splitting into its own PR.

## Checklist
- [x] I have reviewed the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
dbeatty10
dbeatty10 reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver what do you think about these small suggestions?

website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
website/docs/reference/global-configs/behavior-changes.md Outdated Show resolved Hide resolved
matthewshaver and others added 3 commits October 3, 2024 12:57
@matthewshaver @dbeatty10
Update website/docs/reference/global-configs/behavior-changes.md
2cfa8f2 
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@matthewshaver @dbeatty10
Apply suggestions from code review
027e6d2 
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@matthewshaver @dbeatty10
Update website/docs/reference/global-configs/behavior-changes.md
b1f29f0 
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
dbeatty10
dbeatty10 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewshaver !

@dbeatty10 dbeatty10 enabled auto-merge (squash) October 3, 2024 17:06
@dbeatty10 dbeatty10 merged commit 39ca60b into current Oct 3, 2024
6 checks passed
@dbeatty10 dbeatty10 deleted the hook-change branch October 3, 2024 17:07
@dbeatty10 dbeatty10 changed the title New behavior changes New behavior changes: state_modified_compare_more_unrendered and skip_nodes_if_on_run_start_fails Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@graciegoheen graciegoheen Awaiting requested review from graciegoheen

@runleonarun runleonarun Awaiting requested review from runleonarun

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
5 participants
@matthewshaver @graciegoheen @runleonarun @dbeatty10 @mirnawong1