Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing paren in star macro blog #6401

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

kiyanmair
Copy link
Contributor

What are you changing in this pull request and why?

What: Adding a parenthesis which was missing from a code snippet in the blog post "A star (generator) is born" (link).

Why: I noticed this issue while reading the blog post, and people might be confused if they copy and paste the code snippet.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

@kiyanmair kiyanmair requested a review from a team as a code owner November 1, 2024 01:46
Copy link

welcome bot commented Nov 1, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Nov 1, 2024

@kiyanmair is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the developer blog This content fits on the developer blog. label Nov 1, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 1, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Nov 1, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @kiyanmair , thanks for opening this up and great catch! you're absolutely right and I'll get this merged for you! ✨

@mirnawong1 mirnawong1 merged commit 3284ec8 into dbt-labs:current Nov 4, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer blog This content fits on the developer blog. new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants