Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide resolved group-by-items to query-validation rules #1479

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Provide resolved group-by-items to query-validation rules #1479

merged 1 commit into from
Oct 29, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 28, 2024

This PR update the initializer for query-validation rules to include the resolved group-by items. This allows for more efficient validation in a later PR.

@cla-bot cla-bot bot added the cla:yes label Oct 28, 2024
@plypaul plypaul marked this pull request as ready for review October 28, 2024 17:10
@plypaul plypaul merged commit 8294412 into p--short-term-perf--25 Oct 29, 2024
41 checks passed
@plypaul plypaul deleted the p--short-term-perf--26 branch October 29, 2024 22:55
plypaul added a commit that referenced this pull request Oct 29, 2024
@plypaul
Split case handling for different metric types in `MetricTimeQueryVal…
7a715b5 
…idationRule` (#1478)

To improve readability / shorten methods, this PR splits the case
handling for different metrics types in `MetricTimeQueryValidationRule`.

Due to an incorrect merge, this also includes changes in #1479.
@plypaul plypaul restored the p--short-term-perf--26 branch October 30, 2024 01:47
@plypaul plypaul deleted the p--short-term-perf--26 branch October 30, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serramatutu serramatutu serramatutu approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @serramatutu