Change resolved_primary_entity helper signature
#1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--short-term-perf--30
branch
from
2a5da1b
to
d712d71
Compare
plypaul
force-pushed
the
p--short-term-perf--30
branch
from
d712d71
to
3fc7777
Compare
WilliamDee
approved these changes
Oct 31, 2024
plypaul
force-pushed
the
p--short-term-perf--30
branch
from
3fc7777
to
6b14dbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper method
resolved_primary_entitygets the primary entity in a semantic model. Since semantic models with a measure or a dimension should have a primary entity (enforced by validations), this PR changes that method to raise an exception if one does not exist instead of returningNone.get_primary_entity_else_erroris also removed since it becomes redundant.