Update LinkableSpecName.from_name to parse custom grains
#1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
metricflow-semantics/metricflow_semantics/naming/linkable_spec_name.py
Outdated
Show resolved
Hide resolved
metricflow-semantics/metricflow_semantics/model/semantics/semantic_model_lookup.py
Outdated
Show resolved
Hide resolved
WilliamDee
force-pushed
the
will/linkable-spec-custom-grain
branch
from
bb06c31
to
0b47079
Compare
courtneyholcomb
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With the addition of custom granularities, when we parse the dundered names via
LinkableSpecName.from_name, we need to be able to know whether the grain provided is a custom grain. This means we need to pass that information through to this classmethod.Resolves SL-2971