Update MF to support breaking changes in DSI for custom calendar #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Nov 12, 2024
| @@ -151,5 +155,7 @@ def create(self, name: str, entity_path: Sequence[str] = ()) -> WhereFilterDimen | |||
| rendered_spec_tracker=self._rendered_spec_tracker, | |||
| element_name=structured_name.element_name, | |||
| entity_links=tuple(EntityReference(entity_link_name.lower()) for entity_link_name in entity_path) | |||
| + structured_name.entity_links, | |||
| + tuple( | |||
There was a problem hiding this comment.
this change is just to support case insensitivity right?
There was a problem hiding this comment.
nope, we switched from using DunderedNameFormatter to StructuredLinkableSpecName and that didn't have entity_links: Tuple[EntityReference, ...], but only entity_link_names: Tuple[str, ...]. Now that I think about it, i'll just add a property to make entity_links work in StructuredLinkableSpecName so that we don't need this change
There was a problem hiding this comment.
Ooo ok sounds good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We merged 2 breaking changes in DSI dbt-labs/dbt-semantic-interfaces#363 and dbt-labs/dbt-semantic-interfaces#365 which changed most spec typing that used time granularity to be a
strinstead ofTimeGranularityto enable support for custom granularity. Similarly, there were additional breaking changes to the objects that requires passing incustom_granularity_names. This PR updates all those callsites to be compatible with the new version of DSI (to be released)Resolves SL-3097