Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify JoinToTimeSpineNode #1542

Open
wants to merge 5 commits into
base: court/simp3
Choose a base branch
from
Open

Simplify JoinToTimeSpineNode #1542

wants to merge 5 commits into from

Commits on Nov 21, 2024

  1. Remove use_custom_agg_time_dimension property from JoinToTimeSpineNode 

    It is no longer used.
    @courtneyholcomb
    courtneyholcomb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4ab9720 View commit details
    Browse the repository at this point in the history

  2. Dedupe time spine column-building logic & simplify code 

    The biggest change in this commit is to remove all logic related to building select columns from visit_join_to_time_spine_node(). This logic was duplicated in _make_time_spine_data_set().
That logic is now consolidated to _make_time_spine_data_set(). This is laying the foundation for a change coming up the stack, which will replace _make_time_spine_data_set() with its own
node in the DataflowPlan. There is also some other cleanup in this commit because to make visit_join_to_time_spine_node() simpler and more readable.
    @courtneyholcomb
    courtneyholcomb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0811477 View commit details
    Browse the repository at this point in the history

  3. Fix bug related to sorting columns in snapshots 

    This sorting was not commprehensive and resulted in inconsistent snapshots. Removed the custom sorting here and retained the original order, instead.
    @courtneyholcomb
    courtneyholcomb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    bd81bb5 View commit details
    Browse the repository at this point in the history

  4. Update DuckDB snapshots

    @courtneyholcomb
    courtneyholcomb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f5666bc View commit details
    Browse the repository at this point in the history

  5. Update snapshots for other SQL engines

    @courtneyholcomb
    courtneyholcomb committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0781ab3 View commit details
    Browse the repository at this point in the history